Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate DataFrame.label_encoding, use private _label_encoding method internally. #9535

Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Oct 27, 2021

This PR addresses part of #9474 by deprecating DataFrame.label_encoding and adding a private method that can be used internally without raising a FutureWarning until the public API is removed and internals are refactored. See #9474 for more information.

@bdice bdice added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. tech debt non-breaking Non-breaking change labels Oct 27, 2021
@bdice bdice self-assigned this Oct 27, 2021
@bdice bdice requested a review from a team as a code owner October 27, 2021 16:38
@bdice bdice added the bug Something isn't working label Oct 27, 2021
@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #9535 (672a428) into branch-21.12 (ab4bfaa) will decrease coverage by 0.13%.
The diff coverage is n/a.

❗ Current head 672a428 differs from pull request most recent head d47afaf. Consider uploading reports for the commit d47afaf to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9535      +/-   ##
================================================
- Coverage         10.79%   10.65%   -0.14%     
================================================
  Files               116      117       +1     
  Lines             18869    19332     +463     
================================================
+ Hits               2036     2059      +23     
- Misses            16833    17273     +440     
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/sorting.py 92.90% <0.00%> (-1.21%) ⬇️
python/cudf/cudf/io/csv.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/reshape.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/dtypes.py 0.00% <0.00%> (ø)
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8f23c1...d47afaf. Read the comment docs.

@vyasr vyasr removed the request for review from marlenezw October 28, 2021 22:52
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Oct 29, 2021
@galipremsagar
Copy link
Contributor

@gpucibot merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants