Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Java bindings for rolling window stddev aggregation #9527

Merged
merged 3 commits into from
Oct 27, 2021
Merged

Add Java bindings for rolling window stddev aggregation #9527

merged 3 commits into from
Oct 27, 2021

Conversation

razajafri
Copy link
Contributor

This PR adds Java bindings for standard deviation for windowing

  • Adds a test to ColumnVectorTest.java to test the ddof = 1 and 2

@razajafri razajafri added feature request New feature or request Java Affects Java cuDF API. 4 - Needs cuDF (Java) Reviewer non-breaking Non-breaking change labels Oct 26, 2021
@razajafri razajafri self-assigned this Oct 26, 2021
@razajafri razajafri requested a review from a team as a code owner October 26, 2021 17:24
@razajafri razajafri changed the title Java bindings for stddev Add Java bindings for stddev Oct 26, 2021
@razajafri razajafri added improvement Improvement / enhancement to an existing function Spark Functionality that helps Spark RAPIDS and removed feature request New feature or request labels Oct 26, 2021
@codecov
Copy link

codecov bot commented Oct 26, 2021 •
edited
Loading

Codecov Report

Merging #9527 (8a4c456) into branch-21.12 (ab4bfaa) will decrease coverage by 0.12%.
The diff coverage is n/a.

❗ Current head 8a4c456 differs from pull request most recent head 1140137. Consider uploading reports for the commit 1140137 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9527      +/-   ##
================================================
- Coverage         10.79%   10.66%   -0.13%     
================================================
  Files               116      117       +1     
  Lines             18869    19722     +853     
================================================
+ Hits               2036     2104      +68     
- Misses            16833    17618     +785
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/sorting.py 92.90% <0.00%> (-1.21%) ⬇️
python/cudf/cudf/io/csv.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0951ba...1140137. Read the comment docs.

@jlowe jlowe changed the title Add Java bindings for stddev Add Java bindings for rolling window stddev aggregation Oct 26, 2021
@razajafri
Copy link
Contributor Author

rerun tests

@razajafri razajafri mentioned this pull request Oct 26, 2021
Merged
@razajafri
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 2e76b1a into rapidsai:branch-21.12 Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

Assignees

@razajafri razajafri

Labels
improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@razajafri @jlowe