Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable running tests using RMM arena and async memory resources #9506

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

rongou
Copy link
Contributor

@rongou rongou commented Oct 22, 2021

Since Spark uses both the arena and the cuda async allocators, it is useful to run the c++ tests using these allocators.

@rongou rongou added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. RMM Spark Functionality that helps Spark RAPIDS improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 22, 2021
@rongou rongou self-assigned this Oct 22, 2021
@rongou rongou requested a review from a team as a code owner October 22, 2021 22:21
@codecov
Copy link

codecov bot commented Oct 23, 2021

Codecov Report

Merging #9506 (cfca2ab) into branch-21.12 (ab4bfaa) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9506      +/-   ##
================================================
- Coverage         10.79%   10.67%   -0.12%     
================================================
  Files               116      117       +1     
  Lines             18869    19714     +845     
================================================
+ Hits               2036     2104      +68     
- Misses            16833    17610     +777     
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/sorting.py 92.90% <0.00%> (-1.21%) ⬇️
python/cudf/cudf/io/csv.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72694d2...cfca2ab. Read the comment docs.

@harrism harrism changed the title allow running tests using rmm arena/async allocators Enable running tests using RMM arena and async memory resources Oct 26, 2021
@harrism
Copy link
Member

harrism commented Oct 26, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5cd3003 into rapidsai:branch-21.12 Oct 26, 2021
@rongou rongou deleted the more-rmm-modes branch November 23, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants