Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve hash_columns FutureWarning in dask_cudf #9481

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

pentschev
Copy link
Member

Resolve the following FutureWarning raised in dask_cudf when using safe_hash:

FutureWarning: The `hash_columns` method will be removed in a future cuDF release. Replace `df.hash_columns(columns, method)` with `df[columns].hash_values(method)`.

This blocks Dask-CUDA CI, as we're following a strict policy towards deprecation warnings.

@pentschev pentschev requested a review from a team as a code owner October 20, 2021 10:56
@github-actions github-actions bot added the Python Affects Python cuDF API. label Oct 20, 2021
@galipremsagar galipremsagar added bug Something isn't working non-breaking Non-breaking change labels Oct 20, 2021
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #9481 (08ea647) into branch-21.12 (ab4bfaa) will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9481      +/-   ##
================================================
- Coverage         10.79%   10.64%   -0.15%     
================================================
  Files               116      117       +1     
  Lines             18869    19760     +891     
================================================
+ Hits               2036     2104      +68     
- Misses            16833    17656     +823     
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/sorting.py 92.90% <0.00%> (-1.21%) ⬇️
python/cudf/cudf/io/csv.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb98505...08ea647. Read the comment docs.

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Oct 20, 2021
@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit fc868b8 into rapidsai:branch-21.12 Oct 20, 2021
@pentschev
Copy link
Member Author

Thanks @galipremsagar for review/merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants