Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename strings/array_tests.cu to strings/array_tests.cpp #9480

Merged

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Oct 20, 2021

This PR renames cpp/tests/strings/array_tests.cu to .cpp file and cleans up several test cases. The gtests that required a .cu extension called the cudf::strings::detail::scatter function directly. This was created when cudf::scatter had not yet supported strings columns. Changing this to just calling cudf::scatter allows removing device code dependencies.

Also, the GatherTooBig test case was taking over 16s to run. Too much time was spent building fake data to just verify an exception. This PR fixes the fake data (which is never actually read) to speed up it's creation.

Finally, this PR includes removing the hash_string.cu since it is redundant with the hashing/hash_test.cpp which already covers strings inputs. The hash_string.cu had been created before strings support was added to cudf::hash.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 20, 2021
@davidwendt davidwendt self-assigned this Oct 20, 2021
@github-actions github-actions bot added the CMake CMake build issue label Oct 20, 2021
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #9480 (52a1163) into branch-21.12 (ab4bfaa) will decrease coverage by 0.14%.
The diff coverage is n/a.

❗ Current head 52a1163 differs from pull request most recent head 2d38f7b. Consider uploading reports for the commit 2d38f7b to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9480      +/-   ##
================================================
- Coverage         10.79%   10.64%   -0.15%     
================================================
  Files               116      117       +1     
  Lines             18869    19363     +494     
================================================
+ Hits               2036     2062      +26     
- Misses            16833    17301     +468     
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/sorting.py 92.90% <0.00%> (-1.21%) ⬇️
python/cudf/cudf/io/csv.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/reshape.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/dtypes.py 0.00% <0.00%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb98505...2d38f7b. Read the comment docs.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Oct 20, 2021
@davidwendt davidwendt marked this pull request as ready for review October 20, 2021 12:52
@davidwendt davidwendt requested a review from a team as a code owner October 20, 2021 12:52
@harrism
Copy link
Member

harrism commented Oct 20, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 52b7a9e into rapidsai:branch-21.12 Oct 20, 2021
@davidwendt davidwendt deleted the rework-strings-array-tests branch October 21, 2021 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants