Rename strings/array_tests.cu to strings/array_tests.cpp #9480
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames
cpp/tests/strings/array_tests.cu
to.cpp
file and cleans up several test cases. The gtests that required a.cu
extension called thecudf::strings::detail::scatter
function directly. This was created whencudf::scatter
had not yet supported strings columns. Changing this to just callingcudf::scatter
allows removing device code dependencies.Also, the
GatherTooBig
test case was taking over 16s to run. Too much time was spent building fake data to just verify an exception. This PR fixes the fake data (which is never actually read) to speed up it's creation.Finally, this PR includes removing the
hash_string.cu
since it is redundant with thehashing/hash_test.cpp
which already covers strings inputs. Thehash_string.cu
had been created before strings support was added tocudf::hash
.