Fix regex handling of embedded null characters #9470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
bug
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9470 +/- ##
================================================
- Coverage 10.79% 10.66% -0.13%
================================================
Files 116 117 +1
Lines 18869 19725 +856
================================================
+ Hits 2036 2104 +68
- Misses 16833 17621 +788
Continue to review full report at Codecov.
|
davidwendt
added
3 - Ready for Review
|
@andygrove @revans2 Could you try this change to see if it fixes #6196 (and it's duplicate #9440) for you? |
|
Thanks @davidwendt I ran an integration test with the spark plugin and confirmed that this fixes the issue. |
bdice
requested changes
Oct 25, 2021
cwharris
approved these changes
Oct 26, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6196
This fixes the regex pattern-matching logic to handle embedded null characters in a strings column like literals. The matching logic was previously identifying a 0-valued character (same as a null) as a flag to indicate the end of the string. A gtest is also included to test ignoring and matching on a null character.