Fix bug in dask_cudf.read_parquet for index=False #9453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjzamora
added
bug
Comment on lines
+90
to
+97
| tmpdir = str(tmpdir) | ||
| path = os.path.join(tmpdir, "test.parquet") | ||
|
|
||
| df2 = ddf.reset_index(drop=True).compute() | ||
| df2.to_parquet(path, engine="pyarrow") | ||
|
|
||
| ddf3 = dask_cudf.read_parquet(path, index=False) | ||
| dd.assert_eq(df2, ddf3) |
There was a problem hiding this comment.
Suggested change
| tmpdir = str(tmpdir) | |
| path = os.path.join(tmpdir, "test.parquet") | |
| df2 = ddf.reset_index(drop=True).compute() | |
| df2.to_parquet(path, engine="pyarrow") | |
| ddf3 = dask_cudf.read_parquet(path, index=False) | |
| dd.assert_eq(df2, ddf3) | |
| bytes_buf = BytesIO() | |
| df2 = ddf.reset_index(drop=True).compute() | |
| df2.to_parquet(bytes_buf, engine="pyarrow") | |
| ddf3 = dask_cudf.read_parquet(bytes_buf, index=False) | |
| dd.assert_eq(df2, ddf3) |
Can we use BytesIO instead of interacting with Filesystem?
There was a problem hiding this comment.
Ooo - I like your thinking here, but we cannot pass a BytesIO object to dask_cudf.read_parquet without making some much larger changes :)
There was a problem hiding this comment.
Ah, I see. I thought dask_cudf.read_parquet accepts Bytes like object similar to pyarrow/cudf/pandas. Then lets not do it now.
galipremsagar
approved these changes
Oct 15, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9453 +/- ##
================================================
+ Coverage 10.79% 10.82% +0.03%
================================================
Files 116 117 +1
Lines 18869 19454 +585
================================================
+ Hits 2036 2106 +70
- Misses 16833 17348 +515
Continue to review full report at Codecov.
|
galipremsagar
added
5 - Ready to Merge
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix for case that index=False in
dask_cudf.read_parquet(the default/general case in NVTabular).