Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cudf python groupby.diff #9446

Merged
merged 4 commits into from
Oct 21, 2021
Merged

Add cudf python groupby.diff #9446

merged 4 commits into from
Oct 21, 2021

Conversation

karthikeyann
Copy link
Contributor

@karthikeyann karthikeyann commented Oct 15, 2021 •
edited
Loading

Fixes #5079

  • add cudf python groupby diff (implemented using groupby.shift)
  • add unit tests

@karthikeyann karthikeyann added feature request New feature or request 2 - In Progress Currently a work in progress Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Oct 15, 2021
@karthikeyann karthikeyann changed the title Add cudf python groupby.diff Add cudf python groupby.diff [skip-ci] Oct 15, 2021
@karthikeyann karthikeyann mentioned this pull request Oct 15, 2021
Closed
@karthikeyann karthikeyann marked this pull request as ready for review October 15, 2021 09:44
@karthikeyann karthikeyann requested a review from a team as a code owner October 15, 2021 09:44
@karthikeyann karthikeyann added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Oct 15, 2021
@karthikeyann karthikeyann changed the title Add cudf python groupby.diff [skip-ci] Add cudf python groupby.diff Oct 15, 2021
@karthikeyann
Copy link
Contributor Author

OK to test

@codecov
Copy link

codecov bot commented Oct 15, 2021 •
edited
Loading

Codecov Report

Merging #9446 (7182cfb) into branch-21.12 (ab4bfaa) will decrease coverage by 0.15%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9446      +/-   ##
================================================
- Coverage         10.79%   10.63%   -0.16%     
================================================
  Files               116      117       +1     
  Lines             18869    19781     +912     
================================================
+ Hits               2036     2104      +68     
- Misses            16833    17677     +844
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/_lib/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/_lib/strings/__init__.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/sorting.py 92.90% <0.00%> (-1.21%) ⬇️
python/cudf/cudf/io/csv.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08ae072...7182cfb. Read the comment docs.

@karthikeyann
Copy link
Contributor Author

rerun tests

@shwina
Copy link
Contributor

shwina commented Oct 21, 2021

Awesome work! Thanks, @karthikeyann!

@shwina
Copy link
Contributor

shwina commented Oct 21, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 23de7d0 into rapidsai:branch-21.12 Oct 21, 2021
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Python) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@shwina shwina shwina approved these changes

@marlenezw marlenezw Awaiting requested review from marlenezw marlenezw is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@skirui-source skirui-source Awaiting requested review from skirui-source skirui-source is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] groupby diff()
4 participants
@karthikeyann @shwina @galipremsagar @vyasr