Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow int-like objects for the decimals argument in round #9428

Merged
merged 2 commits into from
Oct 14, 2021

Conversation

shwina
Copy link
Contributor

@shwina shwina commented Oct 13, 2021

No description provided.

@shwina shwina requested a review from a team as a code owner October 13, 2021 13:15
@github-actions github-actions bot added the Python Affects Python cuDF API. label Oct 13, 2021
@galipremsagar
Copy link
Contributor

rerun tests

@galipremsagar galipremsagar added bug Something isn't working non-breaking Non-breaking change labels Oct 13, 2021
@jjacobelli
Copy link
Contributor

rerun tests

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #9428 (2970af8) into branch-21.12 (ab4bfaa) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 2970af8 differs from pull request most recent head e912a4b. Consider uploading reports for the commit e912a4b to get more accurate results
Impacted file tree graph

@@              Coverage Diff               @@
##           branch-21.12    #9428    +/-   ##
==============================================
  Coverage         10.79%   10.79%            
==============================================
  Files               116      117     +1     
  Lines             18869    19433   +564     
==============================================
+ Hits               2036     2098    +62     
- Misses            16833    17335   +502     
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/_lib/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/_lib/strings/__init__.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/sorting.py 93.52% <0.00%> (-0.60%) ⬇️
python/cudf/cudf/io/csv.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f47480...e912a4b. Read the comment docs.

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Oct 14, 2021
@galipremsagar
Copy link
Contributor

rerun tests

@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a85b56f into rapidsai:branch-21.12 Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants