-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ctest memcheck using cuda-sanitizer #9414
add ctest memcheck using cuda-sanitizer #9414
Conversation
export GTEST_CUDF_RMM_MODE=cuda ninja rebuild_cache ctest [-T memcheck]
Just wanted add here that the |
Right. It doesn't affect this script. ERROR_TEST can be excluded using |
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9414 +/- ##
================================================
- Coverage 10.79% 10.74% -0.05%
================================================
Files 116 116
Lines 18869 19502 +633
================================================
+ Hits 2036 2096 +60
- Misses 16833 17406 +573
Continue to review full report at Codecov.
|
Also, the |
CC @robertmaynard as resident cmake expert. |
I am a fan of |
@gpucibot merge |
addresses part of #904 and pre-requisite for https://github.com/rapidsai/ops/issues/1462
cuda-sanitizer
as memcheck tool in ctest.GTEST_CUDF_RMM_MODE
in gtests fixtureThis PR enables the unit tests to run under
compute-sanitizer --tool memcheck
in gpuCI nightly or weekly builds.The main issue pending in this PR is to find suitable way for specifying "--rmm_mode=cuda" only in memcheck runs.
ctest
doesn't allow passing arguments to tests yet (ctest feature request).So, options are
export GTEST_CUDF_RMM_MODE=cuda; ninja rebuild_cache; ctest -T memcheck
export GTEST_CUDF_RMM_MODE=cuda; ctest -T memcheck
Which method is most suitable? implemented [5]