Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Several Series Function to Frame #9394

Merged
merged 4 commits into from
Oct 15, 2021

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Oct 6, 2021

This PR moves several functions into Frame, naturally enabling their functionality for dataframe.

closes #8614

@isVoid isVoid requested a review from a team as a code owner October 6, 2021 22:55
@isVoid isVoid added the non-breaking Non-breaking change label Oct 6, 2021
@github-actions github-actions bot added the Python Affects Python cuDF API. label Oct 6, 2021
@isVoid isVoid added feature request New feature or request 3 - Ready for Review Ready for review by team and removed Python Affects Python cuDF API. labels Oct 6, 2021
@isVoid isVoid self-assigned this Oct 6, 2021
@isVoid isVoid added the Python Affects Python cuDF API. label Oct 6, 2021
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #9394 (c5ba1f0) into branch-21.12 (ab4bfaa) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head c5ba1f0 differs from pull request most recent head be63fd8. Consider uploading reports for the commit be63fd8 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9394      +/-   ##
================================================
- Coverage         10.79%   10.78%   -0.01%     
================================================
  Files               116      117       +1     
  Lines             18869    19442     +573     
================================================
+ Hits               2036     2097      +61     
- Misses            16833    17345     +512     
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/_lib/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/_lib/strings/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/csv.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 0.00% <0.00%> (ø)
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 061aa3a...be63fd8. Read the comment docs.

@charlesbluca
Copy link
Member

rerun tests

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Oct 15, 2021
@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 08ae072 into rapidsai:branch-21.12 Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] abs function for dataframe class
4 participants