Add cudf strings is_title API #9380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
feature request
galipremsagar
approved these changes
Oct 5, 2021
karthikeyann
requested changes
Oct 5, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9380 +/- ##
================================================
- Coverage 10.79% 10.75% -0.04%
================================================
Files 116 116
Lines 18869 19482 +613
================================================
+ Hits 2036 2096 +60
- Misses 16833 17386 +553
Continue to review full report at Codecov.
|
bdice
requested changes
Oct 7, 2021
bdice
reviewed
Oct 8, 2021
bdice
reviewed
Oct 11, 2021
bdice
approved these changes
Oct 11, 2021
There was a problem hiding this comment.
@davidwendt Thanks! I left one small suggestion to rename "alpha" to "cased", otherwise LGTM. I learned a lot about the many strange behaviors of Unicode while reviewing.
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5265
This PR adds the libcudf
cudf::strings::is_title()function and the cudf pythonistitle()function for strings column/series. This includes corresponding gtest and pytest for this feature.As mentioned in #5265 this function is equivalent for Pandas and pyspark which follow the logic referenced here https://pandas.pydata.org/docs/reference/api/pandas.Series.str.istitle.html