Add IndexedFrame class and move SingleColumnFrame to a separate module #9378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9378 +/- ##
==============================================
Coverage 10.79% 10.79%
==============================================
Files 116 117 +1
Lines 18869 19427 +558
==============================================
+ Hits 2036 2098 +62
- Misses 16833 17329 +496
Continue to review full report at Codecov.
|
shwina
reviewed
Oct 6, 2021
vyasr
force-pushed
the
refactor/indexed_frame
branch
from
b011d0f
to
4f1bd5d
Compare
vyasr
commented
Oct 12, 2021
| @@ -500,95 +499,6 @@ def _explode(self, explode_column: Any, ignore_index: bool): | |||
| res.index.names = self._index.names | |||
| return res | |||
|
|
|||
| def _sort_index( | |||
There was a problem hiding this comment.
An FYI for reviewers: This method is the result of a bad rebase of mine on a previous PR. It is redundant (replaced by the non-underscored sort_index method below) and safe to remove.
shwina
approved these changes
Oct 13, 2021
vyasr
force-pushed
the
refactor/indexed_frame
branch
from
caffdd9
to
3efe8a2
Compare
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new IndexedFrame subclass of Frame. For the moment this is a minimal class with one user-facing method and the indexer properties, but as we make progress on #9038 we are likely to find more methods that should live here. Additionally, once we remove references to Frame and Index types from the Cython layer of cudf we will be able to move all index-related logic from Frame into this class and provide a suitable ducktyped interface for methods that need to behave differently for frames depending on whether or not they have an index.
In the process I also moved SingleColumnFrame into its own module. One class per file is a good organizational pattern, especially for huge classes like these, and it can also help reduce issues with circular imports and improve mypy runtime.