Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cudf_assert in cudf::io::orc::gpu::gpuDecodeOrcColumnData #9348

Merged
merged 5 commits into from
Oct 5, 2021

Conversation

davidwendt
Copy link
Contributor

This fixes the cudf_assert check in an ORC reader device function that checks an offsets value does not exceed a size_type. The assert expression was just coded backwards and so was being triggered for valid values.

This PR fixes the assert expression.

The assert only occurs in a debug build since it is compiled out of a release build. Also, test code for this code path was only recently added.

@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. cuIO cuIO issue non-breaking Non-breaking change labels Sep 30, 2021
@davidwendt davidwendt self-assigned this Sep 30, 2021
@davidwendt davidwendt requested a review from a team as a code owner September 30, 2021 15:05
@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #9348 (fb4ecf3) into branch-21.12 (ab4bfaa) will decrease coverage by 0.03%.
The diff coverage is 1.76%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9348      +/-   ##
================================================
- Coverage         10.79%   10.75%   -0.04%     
================================================
  Files               116      116              
  Lines             18869    19482     +613     
================================================
+ Hits               2036     2096      +60     
- Misses            16833    17386     +553     
Impacted Files Coverage Δ
python/cudf/cudf/_lib/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/_base_index.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/datetime.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/lists.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/numerical.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/string.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/timedelta.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6593339...fb4ecf3. Read the comment docs.

@karthikeyann
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 56edd42 into rapidsai:branch-21.12 Oct 5, 2021
@davidwendt davidwendt deleted the debug-orc-assert-list branch October 5, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants