-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cudf_assert in cudf::io::orc::gpu::gpuDecodeOrcColumnData #9348
Merged
rapids-bot
merged 5 commits into
rapidsai:branch-21.12
from
davidwendt:debug-orc-assert-list
Oct 5, 2021
Merged
Fix cudf_assert in cudf::io::orc::gpu::gpuDecodeOrcColumnData #9348
rapids-bot
merged 5 commits into
rapidsai:branch-21.12
from
davidwendt:debug-orc-assert-list
Oct 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
bug
Something isn't working
3 - Ready for Review
Ready for review by team
libcudf
Affects libcudf (C++/CUDA) code.
cuIO
cuIO issue
non-breaking
Non-breaking change
labels
Sep 30, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9348 +/- ##
================================================
- Coverage 10.79% 10.75% -0.04%
================================================
Files 116 116
Lines 18869 19482 +613
================================================
+ Hits 2036 2096 +60
- Misses 16833 17386 +553
Continue to review full report at Codecov.
|
robertmaynard
approved these changes
Oct 4, 2021
jrhemstad
approved these changes
Oct 5, 2021
karthikeyann
approved these changes
Oct 5, 2021
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
bug
Something isn't working
cuIO
cuIO issue
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
cudf_assert
check in an ORC reader device function that checks an offsets value does not exceed asize_type
. The assert expression was just coded backwards and so was being triggered for valid values.This PR fixes the assert expression.
The assert only occurs in a debug build since it is compiled out of a release build. Also, test code for this code path was only recently added.