Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use f-string in join helper warning message. #9325

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Sep 28, 2021

Tiny fix to use an f-string in a warning message.

Current output:

.../cudf/python/cudf/cudf/core/join/_join_helpers.py:126: UserWarning: Can't safely cast column from float32 to int8, upcasting to {common_type}.

@bdice bdice requested a review from a team as a code owner September 28, 2021 18:05
@github-actions github-actions bot added the Python Affects Python cuDF API. label Sep 28, 2021
@bdice bdice added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change and removed Python Affects Python cuDF API. labels Sep 28, 2021
@bdice bdice self-assigned this Sep 28, 2021
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working and removed 3 - Ready for Review Ready for review by team labels Sep 28, 2021
@vyasr
Copy link
Contributor

vyasr commented Sep 28, 2021

@gpucibot merge

@bdice
Copy link
Contributor Author

bdice commented Sep 28, 2021

It appears that there are unrelated failures in dask_cudf CI.

@bdice
Copy link
Contributor Author

bdice commented Sep 28, 2021

rerun tests

@vyasr
Copy link
Contributor

vyasr commented Sep 28, 2021

@bdice CI is currently blocked until #9322 can be merged and incompatibilities with dask/dask#8167 can be resolved, I assume those are the errors that you ran into.

@galipremsagar
Copy link
Contributor

rerun tests

@rapids-bot rapids-bot bot merged commit bef2c35 into branch-21.12 Sep 29, 2021
@bdice bdice deleted the join-helper-warning-fstring branch September 29, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants