Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc reorder mr, stream to stream, mr #9308

Merged
merged 2 commits into from
Oct 1, 2021

Conversation

karthikeyann
Copy link
Contributor

Doc reorder mr, stream to stream, mr

@karthikeyann karthikeyann added 3 - Ready for Review Ready for review by team doc Documentation tech debt non-breaking Non-breaking change labels Sep 24, 2021
@karthikeyann karthikeyann requested a review from a team as a code owner September 24, 2021 21:45
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Sep 24, 2021
@codecov
Copy link

codecov bot commented Sep 25, 2021

Codecov Report

Merging #9308 (94c1111) into branch-21.12 (ab4bfaa) will decrease coverage by 0.00%.
The diff coverage is 2.54%.

❗ Current head 94c1111 differs from pull request most recent head da251ec. Consider uploading reports for the commit da251ec to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9308      +/-   ##
================================================
- Coverage         10.79%   10.78%   -0.01%     
================================================
  Files               116      116              
  Lines             18869    19387     +518     
================================================
+ Hits               2036     2090      +54     
- Misses            16833    17297     +464     
Impacted Files Coverage Δ
python/cudf/cudf/core/_base_index.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/datetime.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/join/_join_helpers.py 0.00% <ø> (ø)
python/cudf/cudf/core/multiindex.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/tools/datetimes.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/udf/api.py 0.00% <0.00%> (ø)
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 165cdac...da251ec. Read the comment docs.

Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:+1
Some minor suggestions to document some peripheral function parameters.

cpp/src/binaryop/compiled/binary_ops.hpp Show resolved Hide resolved
cpp/src/binaryop/compiled/binary_ops.hpp Show resolved Hide resolved
cpp/src/binaryop/compiled/binary_ops.hpp Show resolved Hide resolved
cpp/src/reductions/minmax.cu Show resolved Hide resolved
@karthikeyann
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit cf0b2ca into rapidsai:branch-21.12 Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team doc Documentation libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants