Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added deprecation warning for .label_encoding() #9289

Merged

Conversation

mayankanand007
Copy link
Contributor

This PR addresses issue #8608 by adding a deprecation warning before we remove the functionality entirely.

@github-actions github-actions bot added the Python Affects Python cuDF API. label Sep 23, 2021
@mayankanand007 mayankanand007 marked this pull request as ready for review September 23, 2021 19:39
@mayankanand007 mayankanand007 requested a review from a team as a code owner September 23, 2021 19:39
@beckernick beckernick added doc Documentation non-breaking Non-breaking change labels Sep 23, 2021
@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #9289 (12a4dc1) into branch-21.12 (ab4bfaa) will increase coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9289      +/-   ##
================================================
+ Coverage         10.79%   10.83%   +0.04%     
================================================
  Files               116      116              
  Lines             18869    19258     +389     
================================================
+ Hits               2036     2087      +51     
- Misses            16833    17171     +338     
Impacted Files Coverage Δ
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/feather.py 0.00% <0.00%> (ø)
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2098e5...12a4dc1. Read the comment docs.

@shwina
Copy link
Contributor

shwina commented Sep 24, 2021

@gpucibot merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants