Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align DataFrame.apply signature with pandas #9275

Merged

Conversation

brandon-b-miller
Copy link
Contributor

Aligns the function signature for cudf.DataFrame.apply with that of pandas.DataFrame.apply. This is needed so that dask can build on a common apply interface between backends among other reasons.

@brandon-b-miller brandon-b-miller requested a review from a team as a code owner September 22, 2021 20:25
@github-actions github-actions bot added the Python Affects Python cuDF API. label Sep 22, 2021
@brandon-b-miller brandon-b-miller added 3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Non-breaking change labels Sep 22, 2021
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Sep 22, 2021
@galipremsagar
Copy link
Contributor

@gpucibot merge

@galipremsagar
Copy link
Contributor

rerun tests

@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #9275 (9ccae14) into branch-21.10 (3ee3ecf) will decrease coverage by 0.08%.
The diff coverage is 7.69%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.10    #9275      +/-   ##
================================================
- Coverage         10.85%   10.77%   -0.09%     
================================================
  Files               115      116       +1     
  Lines             19158    19321     +163     
================================================
+ Hits               2080     2081       +1     
- Misses            17078    17240     +162     
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/_lib/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/multiindex.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/text.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/dtypes.py 0.00% <ø> (ø)
python/cudf/cudf/utils/ioutils.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/accessors.py 92.30% <100.00%> (+0.64%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cb527f...9ccae14. Read the comment docs.

@rapids-bot rapids-bot bot merged commit ced66b5 into rapidsai:branch-21.10 Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants