Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove zlib from libcudf public CMake dependencies #9204

Merged
merged 4 commits into from
Sep 17, 2021
Merged

Remove zlib from libcudf public CMake dependencies #9204

merged 4 commits into from
Sep 17, 2021

Conversation

robertmaynard
Copy link
Contributor

libcudf doesn't expose zlib in the public facing API, and therefore C++ consumers don't need to also link / include zlib.

@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for Review Ready for review by team CMake CMake build issue labels Sep 9, 2021
@robertmaynard robertmaynard requested a review from a team as a code owner September 9, 2021 16:43
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Sep 9, 2021
@robertmaynard robertmaynard added the non-breaking Non-breaking change label Sep 9, 2021
@robertmaynard
Copy link
Contributor Author

@kkraus14 Followup from your comment about ZLIB::ZLIB

@codecov
Copy link

codecov bot commented Sep 13, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@e04fe79). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9204   +/-   ##
===============================================
  Coverage                ?   10.85%           
===============================================
  Files                   ?      115           
  Lines                   ?    19158           
  Branches                ?        0           
===============================================
  Hits                    ?     2080           
  Misses                  ?    17078           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e04fe79...bb77991. Read the comment docs.

@robertmaynard
Copy link
Contributor Author

rerun tests

kkraus14
kkraus14 reviewed Sep 17, 2021
View reviewed changes
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
@kkraus14
Copy link
Collaborator

@gpucibot merge

1 similar comment
@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 91d412b into rapidsai:branch-21.10 Sep 17, 2021
@robertmaynard robertmaynard deleted the bug/remove_zlib_from_public_deps branch September 17, 2021 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

@harrism harrism harrism approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertmaynard @kkraus14 @harrism