Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isocalendar API support #9169

Merged
merged 64 commits into from
Sep 30, 2021
Merged

Conversation

marlenezw
Copy link
Contributor

@marlenezw marlenezw commented Sep 2, 2021

Closes #8896 #4908.

It creates a new isocalendar method in cudf python, and solves related datetime issues for obtaining week, year and day in isocalendar form.

@github-actions github-actions bot added the Python Affects Python cuDF API. label Sep 2, 2021
@marlenezw marlenezw self-assigned this Sep 2, 2021
@marlenezw marlenezw added this to the Time Series Analysis milestone Sep 2, 2021
@marlenezw marlenezw added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Sep 2, 2021
@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #9169 (5704519) into branch-21.12 (ab4bfaa) will increase coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head 5704519 differs from pull request most recent head 0d25c18. Consider uploading reports for the commit 0d25c18 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9169      +/-   ##
================================================
+ Coverage         10.79%   10.82%   +0.03%     
================================================
  Files               116      116              
  Lines             18869    19287     +418     
================================================
+ Hits               2036     2087      +51     
- Misses            16833    17200     +367     
Impacted Files Coverage Δ
python/cudf/cudf/core/_base_index.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/datetime.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/join/_join_helpers.py 0.00% <ø> (ø)
python/cudf/cudf/core/multiindex.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/tools/datetimes.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd0b710...0d25c18. Read the comment docs.

@marlenezw marlenezw marked this pull request as ready for review September 7, 2021 12:53
@marlenezw marlenezw requested a review from a team as a code owner September 7, 2021 12:53
python/cudf/cudf/core/index.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/index.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/index.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/index.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/series.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/series.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/series.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/series.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/series.py Outdated Show resolved Hide resolved
marlenezw and others added 7 commits September 17, 2021 12:00
Co-authored-by: Ram (Ramakrishna Prabhu) <[email protected]>
Co-authored-by: Ram (Ramakrishna Prabhu) <[email protected]>
Co-authored-by: Ram (Ramakrishna Prabhu) <[email protected]>
Co-authored-by: Ram (Ramakrishna Prabhu) <[email protected]>
Co-authored-by: Ram (Ramakrishna Prabhu) <[email protected]>
Co-authored-by: Ram (Ramakrishna Prabhu) <[email protected]>
Co-authored-by: Ram (Ramakrishna Prabhu) <[email protected]>
@github-actions github-actions bot added CMake CMake build issue conda labels Sep 20, 2021
@github-actions github-actions bot added the conda label Sep 27, 2021
@github-actions github-actions bot removed Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. conda CMake CMake build issue labels Sep 27, 2021
@marlenezw
Copy link
Contributor Author

I think the new updates to yml files are affecting my linters locally, so files that are unrelated are getting linted incorrectly. Spoke to Prem about this, and trying to fix this in compose :D

@marlenezw
Copy link
Contributor Author

rerun tests

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Sep 30, 2021
@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ef50796 into rapidsai:branch-21.12 Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Series datetime isocalendar
5 participants