Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import rapids-cmake modules using the correct cmake variable. #9149

Conversation

robertmaynard
Copy link
Contributor

Use rapids-cmake-dir when computing the location of rapids-cmake modules.

Corrects build errors that occur when CUDF_BUILD_BENCHMARKS is enabled.

@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for Review Ready for review by team CMake CMake build issue non-breaking Non-breaking change labels Aug 31, 2021
@robertmaynard robertmaynard requested a review from a team as a code owner August 31, 2021 13:44
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 31, 2021
@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@8a3efd0). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 8bed337 differs from pull request most recent head a2bb9cd. Consider uploading reports for the commit a2bb9cd to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9149   +/-   ##
===============================================
  Coverage                ?   10.85%           
===============================================
  Files                   ?      114           
  Lines                   ?    19068           
  Branches                ?        0           
===============================================
  Hits                    ?     2070           
  Misses                  ?    16998           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a3efd0...a2bb9cd. Read the comment docs.

@harrism
Copy link
Member

harrism commented Aug 31, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 549bcb7 into rapidsai:branch-21.10 Aug 31, 2021
@robertmaynard robertmaynard deleted the bug/correctly_import_rapids-cmake_module branch September 1, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants