Support null literals in expressions #9117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'t compile because we can't check scalar device view validity on the host.
vyasr
added
bug
jlowe
approved these changes
Aug 25, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #9117 +/- ##
===============================================
Coverage ? 10.77%
===============================================
Files ? 115
Lines ? 18722
Branches ? 0
===============================================
Hits ? 2018
Misses ? 16704
Partials ? 0 Continue to review full report at Codecov.
|
Fix typo Co-authored-by: Jason Lowe <[email protected]>
|
rerun tests |
1 similar comment
|
rerun tests |
bdice
requested changes
Sep 3, 2021
…_8831 # Conflicts: # cpp/src/ast/expression_parser.cpp
bdice
approved these changes
Sep 7, 2021
hyperbolic2346
approved these changes
Sep 7, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #8831 by propagating null values appropriately when they are provided in the form of literals. In addition to adding support at the level of expression evaluation, this PR also adds the appropriate dispatch to the correct code path at the level of calls to APIs using expressions containing nulls so that the null-supporting code paths can be triggered even when operating on tables that do not contain any nulls.