Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify write_csv by removing unnecessary writer/impl classes #9089

Merged
merged 34 commits into from
Nov 18, 2021
Merged

Simplify write_csv by removing unnecessary writer/impl classes #9089

merged 34 commits into from
Nov 18, 2021

Commits on Aug 14, 2021

  1. simplify io/functions.cpp data source/sink factories

    @cwharris
    cwharris committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    9c72e56 View commit details
    Browse the repository at this point in the history

  2. begin replacing csv_reader with pure functions

    @cwharris
    cwharris committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    9e92ca2 View commit details
    Browse the repository at this point in the history

  3. pass parse_options explicitly in csv_reader

    @cwharris
    cwharris committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    6492349 View commit details
    Browse the repository at this point in the history

  4. replace csv reader impl::select_data_types with pure function

    @cwharris
    cwharris committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    3e365b5 View commit details
    Browse the repository at this point in the history

  5. replace csv reader impl::column_flags_ member with local variable

    @cwharris
    cwharris committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    a4497c0 View commit details
    Browse the repository at this point in the history

  6. make csv reader impl::find_first_row_start a standalone function

    @cwharris
    cwharris committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    6d708b7 View commit details
    Browse the repository at this point in the history

  7. make csv reader impl:col_names_ a local variable

    @cwharris
    cwharris committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    26e37e2 View commit details
    Browse the repository at this point in the history

  8. replace csv reader impl::num_records with local variable.

    @cwharris
    cwharris committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    9d84753 View commit details
    Browse the repository at this point in the history

  9. convert csv reader impl ::num_actual_columns and ::num_active_columns… 

    … to local variables
    @cwharris
    cwharris committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    7ce862e View commit details
    Browse the repository at this point in the history

  10. remove csv reader class and impl class in favor of fucntions

    @cwharris
    cwharris committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    9010fe1 View commit details
    Browse the repository at this point in the history

  11. rearrange some functions to delete some unneccessary declarations.

    @cwharris
    cwharris committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    7cda106 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2021

  1. Merge branch 'branch-21.10' of github.com:rapidsai/cudf into io-funct… 

    …ions-simplify
    @cwharris
    cwharris committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    884bde6 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2021

  1. remove filepath-related logic from csv and json readers

    @cwharris
    cwharris committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    88e2399 View commit details
    Browse the repository at this point in the history

  2. remove filepath logic from avro, parquet, orc readers

    @cwharris
    cwharris committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    62b9520 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2021

  1. move range size padding calculation out of json/csv reader and in to … 

    …json/csv options
    @cwharris
    cwharris committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    fb01294 View commit details
    Browse the repository at this point in the history

  2. remove filepaths from json reader

    @cwharris
    cwharris committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    d422aeb View commit details
    Browse the repository at this point in the history

  3. Merge branch 'io-functions-simplify' into io-simplify-csv

    @cwharris
    cwharris committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    a67150e View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2021

  1. remove unncessary csv writer class

    @cwharris
    cwharris committed Aug 21, 2021
    Configuration menu
    Copy the full SHA
    4808a43 View commit details
    Browse the repository at this point in the history

  2. replace csv::writer_impl out_sink_ member with local variable

    @cwharris
    cwharris committed Aug 21, 2021
    Configuration menu
    Copy the full SHA
    9688d77 View commit details
    Browse the repository at this point in the history

  3. replace csv::writer_impl members with local variables

    @cwharris
    cwharris committed Aug 21, 2021
    Configuration menu
    Copy the full SHA
    7840dc5 View commit details
    Browse the repository at this point in the history

  4. remove unnecessary csv writer impl class

    @cwharris
    cwharris committed Aug 21, 2021
    Configuration menu
    Copy the full SHA
    16e4eee View commit details
    Browse the repository at this point in the history

  5. replace writer_impl.hpp with more appropriately named durations.hpp

    @cwharris
    cwharris committed Aug 21, 2021
    Configuration menu
    Copy the full SHA
    9994ea3 View commit details
    Browse the repository at this point in the history

  6. re-delete csv reader_impl header

    @cwharris
    cwharris committed Aug 21, 2021
    Configuration menu
    Copy the full SHA
    640375b View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2021

  1. Merge branch 'branch-21.10' of github.com:rapidsai/cudf into io-simpl… 

    …ify-csv
    @cwharris
    cwharris committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    051f0ce View commit details
    Browse the repository at this point in the history

  2. Merge branch 'io-simplify-csv' into io-simplify-csv-writer

    @cwharris
    cwharris committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    b86e63f View commit details
    Browse the repository at this point in the history

  3. re-remove csv/reader_impl.hpp

    @cwharris
    cwharris committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    07b05e8 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2021

  1. fix bad merge where changes in 9079 were deleted.

    @cwharris
    cwharris committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    92033c3 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2021

  1. add back read_csv impl function get_data_types_from_column_names

    @cwharris
    cwharris committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    24b3949 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2021

  1. Merge branch 'branch-21.12' into io-simplify-csv

    @cwharris
    cwharris committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    e8a8887 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'io-simplify-csv' into io-simplify-csv-writer

    @cwharris
    cwharris committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    daeb035 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. Merge branch 'branch-21.12' of github.com:rapidsai/cudf into io-simpl… 

    …ify-csv-writer
    @cwharris
    cwharris committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    4da657a View commit details
    Browse the repository at this point in the history

  2. adjust copyright year

    @cwharris
    cwharris committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    1068510 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'branch-22.02' of github.com:rapidsai/cudf into io-simpl… 

    …ify-csv-writer
    @cwharris
    cwharris committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    300af47 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. remove trailing _ in csv writer impl function args

    @cwharris
    cwharris committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    4fa0f44 View commit details
    Browse the repository at this point in the history