Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove stale code in ColumnBase._fill #9078

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Remove stale code in ColumnBase._fill #9078

merged 1 commit into from
Aug 20, 2021

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Aug 19, 2021 •
edited
Loading

This PR removes unreachable code in ColumnBase._fill.
closes #8566

@isVoid isVoid requested a review from a team as a code owner August 19, 2021 22:47
@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 19, 2021
@isVoid isVoid added tech debt 3 - Ready for Review Ready for review by team non-breaking Non-breaking change improvement Improvement / enhancement to an existing function and removed Python Affects Python cuDF API. labels Aug 19, 2021
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Aug 19, 2021
@galipremsagar
Copy link
Contributor

rerun tests

@codecov
Copy link

codecov bot commented Aug 20, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@5f1b7f2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9078   +/-   ##
===============================================
  Coverage                ?   10.71%           
===============================================
  Files                   ?      114           
  Lines                   ?    19090           
  Branches                ?        0           
===============================================
  Hits                    ?     2046           
  Misses                  ?    17044           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f1b7f2...5f0dc8d. Read the comment docs.

@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ca58c1e into rapidsai:branch-21.10 Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@shwina shwina Awaiting requested review from shwina

@charlesbluca charlesbluca Awaiting requested review from charlesbluca

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Strange code logic in ColumnBase._fill
2 participants
@isVoid @galipremsagar