-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java] Added method to remove null_masks if the column has no nulls #9061
[Java] Added method to remove null_masks if the column has no nulls #9061
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #9061 +/- ##
===============================================
Coverage ? 10.73%
===============================================
Files ? 114
Lines ? 19055
Branches ? 0
===============================================
Hits ? 2046
Misses ? 17009
Partials ? 0 Continue to review full report at Codecov.
|
Thanks for the review guys, is there anything else that you want me to change? |
Rerun tests |
@revans2 I have addressed your concerns. I have removed deprecation as it doesn't hurt to keep this API it also makes more sense and is less confusing to users. |
Can I ask for one more review? |
rerun tests |
rerun tests |
@gpucibot merge |
This PR adds a method to remove the validity vector in cases where there are columns in a Table with no nulls but still have a validity vector.