Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Several Series and Dataframe Methods #9059

Merged
merged 10 commits into from
Aug 30, 2021

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Aug 18, 2021

Partly addresses #9038

This function consolidate several (trivial) functions from Series and DataFrame into Frame. __invert__ was consolidated to shared (more efficient) code path using factory methods.
deserialize was not consolidated because we have to provide backward compatibility to older classes. But factory method was used for faster class construction.

@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 18, 2021
@isVoid isVoid added the non-breaking Non-breaking change label Aug 18, 2021
@isVoid isVoid added the improvement Improvement / enhancement to an existing function label Aug 18, 2021
@isVoid isVoid requested a review from vyasr August 19, 2021 21:58
@isVoid isVoid marked this pull request as ready for review August 19, 2021 21:59
@isVoid isVoid requested a review from a team as a code owner August 19, 2021 21:59
@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@5869264). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head a5de9f4 differs from pull request most recent head 5d085a3. Consider uploading reports for the commit 5d085a3 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9059   +/-   ##
===============================================
  Coverage                ?   10.77%           
===============================================
  Files                   ?      114           
  Lines                   ?    19054           
  Branches                ?        0           
===============================================
  Hits                    ?     2054           
  Misses                  ?    17000           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5869264...5d085a3. Read the comment docs.

Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some minor suggestions for improvement.

python/cudf/cudf/core/dataframe.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/dataframe.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/frame.py Show resolved Hide resolved
python/cudf/cudf/core/frame.py Outdated Show resolved Hide resolved
@isVoid isVoid requested a review from vyasr August 24, 2021 17:24
@vyasr
Copy link
Contributor

vyasr commented Aug 25, 2021

@isVoid can you fix style and resolve comments when you get a chance? Then I can re-review.

Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@isVoid isVoid added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Aug 27, 2021
@beckernick
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b2423ac into rapidsai:branch-21.10 Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants