-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate Several Series and Dataframe Methods #9059
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #9059 +/- ##
===============================================
Coverage ? 10.77%
===============================================
Files ? 114
Lines ? 19054
Branches ? 0
===============================================
Hits ? 2054
Misses ? 17000
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had some minor suggestions for improvement.
@isVoid can you fix style and resolve comments when you get a chance? Then I can re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@gpucibot merge |
Partly addresses #9038
This function consolidate several (trivial) functions from
Series
andDataFrame
into Frame.__invert__
was consolidated to shared (more efficient) code path using factory methods.deserialize
was not consolidated because we have to provide backward compatibility to older classes. But factory method was used for faster class construction.