Refactor Index hierarchy #9039
Refactor Index hierarchy #9039
Conversation
vyasr
added
2 - In Progress
|
Rerun tests |
|
rerun tests |
…ndex tests passing.
…r expected behavior.
…e order so that Frame methods take precedence.
…ic implementation.
…ersion out of the loop.
|
The diff just got a lot bigger because of the move, but nothing else of substance changed in the last few commits. |
|
+1 to what Michael suggested! The changes to Overall looks good to me! I had a few questions about some of the changes but I think it looks good! |
python/cudf/cudf/core/index.py
Outdated
| def get_loc(self, key, method=None, tolerance=None): | ||
| return self._as_int64().get_loc( | ||
| key, method=method, tolerance=tolerance | ||
| ) |
There was a problem hiding this comment.
I feel like there's a more efficient way to implement get_loc for RangeIndex. But I'm ok to leave it as is to make it work.
There was a problem hiding this comment.
Oh for sure, I think I thought about this earlier and forgot to implement. The formula should be very straightforward, can you request changes to prevent a merge?
There was a problem hiding this comment.
@isVoid new get_loc is implemented. I hope I got all the edge cases right, let me know if anything looks off.
|
@gpucibot merge |
Until now the class hierarchy of index types has had numerous logical flaws for reasons of convenience: for instance,
RangeIndexwas always inheriting fromFramedespite not actually being backed by data, and since #8115MultiIndexhas been aSingleColumnFrameeven though it actually has multiple columns. This PR movesBaseIndexto the top of its own hierarchy, and uses multiple inheritance withFrameandSingleColumnFrameto create a more sensible hierarchy for its subclasses.BaseIndexis now effectively an ABC defining the interface that subclasses must define, but many of these methods are still inherited fromFrametypes (or in the case ofRangeIndex, delegated toInt64Index).These changes remove lots of broken behavior that was previously present in
MultiIndexandRangeIndex; for instance, binary operations would previously fail in strange ways forMultiIndex, and various hacks were necessary forMultiIndexmethods to bypassSingleColumnFrame.RangeIndexmethods that delegate toInt64Indexare now made explicit (rather than the previous implicit conversion viaself._data). The new hierarchy also allows much more sensible type-checking by mypy, which revealed numerous additional conceptual issues. The bulk of this PR is actually moving functions around to make the type checker happy, some of which also fixed actual functional issues: for example,RangeIndex.get_locwas previously broken. The refactor will make it much easier to handle future changes to all classes in the index hierarchy.