-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Frame scans #9021
Refactor Frame scans #9021
Conversation
Here are some detailed performance numbers for comparison. Benchmarks
Before:
After:
|
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #9021 +/- ##
===============================================
Coverage ? 10.66%
===============================================
Files ? 114
Lines ? 18659
Branches ? 0
===============================================
Hits ? 1990
Misses ? 16669
Partials ? 0 Continue to review full report at Codecov.
|
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, minor comments in pytests..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good to me!
@gpucibot merge |
This pull request is a substantial refactor of the internals of scan operations like
cummax
andcumsum
. The new implementation moves nearly all logic to theFrame
level. The resulting code improves performance and adds support for new features. In particular:Series
operations are now 10-20% faster. More importantly,DataFrame
operations are 2-3x faster.DataFrame
now support axis=1 (previously only reductions likesum
did so).