Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _copy_construct factory #8999

Merged

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Aug 9, 2021

This PR removes the _copy_construct factory method for the Frame types that were still exposing it, replacing its usage with _from_data. The current implementation of _from_data is slightly faster, and more importantly this change leaves us with a single fast path for building Frame objects (bypassing the slow constructors) so that we only have to maintain and optimize one going forward.

@vyasr vyasr added 3 - Ready for Review Ready for review by team code quality Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 9, 2021
@vyasr vyasr added this to the CuDF Python Refactoring milestone Aug 9, 2021
@vyasr vyasr self-assigned this Aug 9, 2021
@vyasr vyasr requested a review from a team as a code owner August 9, 2021 18:32
@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@a4eabf0). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head ac451a2 differs from pull request most recent head a031e8a. Consider uploading reports for the commit a031e8a to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #8999   +/-   ##
===============================================
  Coverage                ?   10.58%           
===============================================
  Files                   ?      116           
  Lines                   ?    18634           
  Branches                ?        0           
===============================================
  Hits                    ?     1972           
  Misses                  ?    16662           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4eabf0...a031e8a. Read the comment docs.

@marlenezw
Copy link
Contributor

Looks really great to me overall! These changes are really good 😄

@vyasr
Copy link
Contributor Author

vyasr commented Aug 10, 2021

rerun tests

@vyasr vyasr requested a review from marlenezw August 10, 2021 19:53
Copy link
Contributor

@marlenezw marlenezw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@vyasr
Copy link
Contributor Author

vyasr commented Aug 11, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c007b1c into rapidsai:branch-21.10 Aug 11, 2021
@vyasr vyasr deleted the refactor/remove_copy_construct branch January 14, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants