Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure JNI native libraries load when CompiledExpression loads #8997

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Aug 9, 2021

CompiledExpression was missing a static block to ensure the native libraries were loaded before the class becomes available for use. This could result in exceptions like the following if no other cudf class with native dependencies is used first in an application:

java.lang.UnsatisfiedLinkError: ai.rapids.cudf.ast.CompiledExpression.compile([B)J
  at ai.rapids.cudf.ast.CompiledExpression.compile(Native Method)
  at ai.rapids.cudf.ast.CompiledExpression.<init>(CompiledExpression.java:65)
  at ai.rapids.cudf.ast.Expression.compile(Expression.java:29)

@jlowe jlowe added bug Something isn't working Java Affects Java cuDF API. 4 - Needs cuDF (Java) Reviewer non-breaking Non-breaking change labels Aug 9, 2021
@jlowe jlowe self-assigned this Aug 9, 2021
@jlowe jlowe requested a review from a team as a code owner August 9, 2021 16:49
@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@a4eabf0). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head c6746ba differs from pull request most recent head 1c86ab3. Consider uploading reports for the commit 1c86ab3 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #8997   +/-   ##
===============================================
  Coverage                ?   10.60%           
===============================================
  Files                   ?      116           
  Lines                   ?    19000           
  Branches                ?        0           
===============================================
  Hits                    ?     2015           
  Misses                  ?    16985           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4eabf0...1c86ab3. Read the comment docs.

@jlowe
Copy link
Member Author

jlowe commented Aug 9, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ed84e44 into rapidsai:branch-21.10 Aug 9, 2021
shwina pushed a commit to shwina/cudf that referenced this pull request Aug 9, 2021
…sai#8997)

`CompiledExpression` was missing a static block to ensure the native libraries were loaded before the class becomes available for use. This could result in exceptions like the following if no other cudf class with native dependencies is used first in an application:
```
java.lang.UnsatisfiedLinkError: ai.rapids.cudf.ast.CompiledExpression.compile([B)J
  at ai.rapids.cudf.ast.CompiledExpression.compile(Native Method)
  at ai.rapids.cudf.ast.CompiledExpression.<init>(CompiledExpression.java:65)
  at ai.rapids.cudf.ast.Expression.compile(Expression.java:29)
```

Authors:
  - Jason Lowe (https://github.com/jlowe)

Approvers:
  - Robert (Bobby) Evans (https://github.com/revans2)

URL: rapidsai#8997
@jlowe jlowe deleted the jni-ast-load-native branch September 10, 2021 15:47
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Needs Review Waiting for reviewer to review or respond bug Something isn't working Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants