Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] ENH Allow arbitrary CMake config options in build.sh #8996

Merged
merged 15 commits into from
Aug 13, 2021
Merged

[REVIEW] ENH Allow arbitrary CMake config options in build.sh #8996

merged 15 commits into from
Aug 13, 2021

Commits on Aug 6, 2021

  1. ENH Allow arbitrary CMake configurations arguments to be used

    @dillon-cullinan
    dillon-cullinan committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    d5f40ec View commit details
    Browse the repository at this point in the history

  2. FIX Clarify usage of --cmake-args option

    @dillon-cullinan
    dillon-cullinan committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    54da767 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2021

  1. FIX Add cmake arg format testing and error msg

    @dillon-cullinan
    dillon-cullinan committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    8f15bdf View commit details
    Browse the repository at this point in the history

  2. FIX Add lookback to error logic

    @dillon-cullinan
    dillon-cullinan committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    76c3d5d View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2021

  1. FIX Catch any possible edge cases that may occur from second regex test

    @dillon-cullinan
    dillon-cullinan committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    369b9df View commit details
    Browse the repository at this point in the history

  2. Reformat regex to look more readable

    @dillon-cullinan
    dillon-cullinan committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    fc6a0d2 View commit details
    Browse the repository at this point in the history

  3. FIX Reformat regex to look more readable

    @dillon-cullinan
    dillon-cullinan committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    0e21a97 View commit details
    Browse the repository at this point in the history

  4. FIX Fix formatting not being recognized when --cmake-args is the last… 

    … argument given
    @dillon-cullinan
    dillon-cullinan committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    6ad7ea5 View commit details
    Browse the repository at this point in the history

  5. FIX Move cmakeArgs option into validArgs function

    @dillon-cullinan
    dillon-cullinan committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    a3ed49d View commit details
    Browse the repository at this point in the history

  6. FIX Correct indentation/spacing

    @dillon-cullinan
    dillon-cullinan committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    443b9e9 View commit details
    Browse the repository at this point in the history

  7. FIX Indentation fixes

    @dillon-cullinan
    dillon-cullinan committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    747c088 View commit details
    Browse the repository at this point in the history

  8. FIX Handle multiple --cmake-args options

    @dillon-cullinan
    dillon-cullinan committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    337c328 View commit details
    Browse the repository at this point in the history

  9. FIX Indentation...

    @dillon-cullinan
    dillon-cullinan committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    74dc4cd View commit details
    Browse the repository at this point in the history

  10. FIX Generalize error message, simplify formatting check

    @dillon-cullinan
    dillon-cullinan committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    82e9e08 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2021

  1. FIX Tabs to spaces in help text

    @dillon-cullinan
    dillon-cullinan committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    73d7811 View commit details
    Browse the repository at this point in the history