Fix debug compile error for csv_test.cpp #8981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
bug
vuule
approved these changes
Aug 5, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #8981 +/- ##
===============================================
Coverage ? 10.58%
===============================================
Files ? 116
Lines ? 18652
Branches ? 0
===============================================
Hits ? 1974
Misses ? 16678
Partials ? 0 Continue to review full report at Codecov.
|
hyperbolic2346
approved these changes
Aug 6, 2021
|
@gpucibot merge |
shwina
pushed a commit
to shwina/cudf
that referenced
this pull request
Aug 9, 2021
Found an compile error in `csv_test.cpp` that only occurs with a debug build since it exists in an `assert()` statement. Looks like this was introduced in PR rapidsai#8856 Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Vukasin Milovanovic (https://github.com/vuule) - Mike Wilson (https://github.com/hyperbolic2346) URL: rapidsai#8981
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found an compile error in
csv_test.cppthat only occurs with a debug build since it exists in anassert()statement.Looks like this was introduced in PR #8856