Java conditional joins should not require matching column counts #8955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlowe
added
bug
revans2
approved these changes
Aug 4, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #8955 +/- ##
===============================================
Coverage ? 10.59%
===============================================
Files ? 116
Lines ? 19036
Branches ? 0
===============================================
Hits ? 2017
Misses ? 17019
Partials ? 0 Continue to review full report at Codecov.
|
|
@gpucibot merge |
shwina
pushed a commit
to shwina/cudf
that referenced
this pull request
Aug 9, 2021
…idsai#8955) The Java conditional join APIs had a copy-n-paste error from the equality join code where it mandated the left and right table column counts matched. Conditional joins use an AST expression for the join condition which does not require a 1-to-1 mapping between left and right table columns, so this check has been removed from the conditional join APIs. Authors: - Jason Lowe (https://github.com/jlowe) Approvers: - Robert (Bobby) Evans (https://github.com/revans2) URL: rapidsai#8955
vyasr
added
4 - Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Java conditional join APIs had a copy-n-paste error from the equality join code where it mandated the left and right table column counts matched. Conditional joins use an AST expression for the join condition which does not require a 1-to-1 mapping between left and right table columns, so this check has been removed from the conditional join APIs.