Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Java AstNode public #8953

Merged
merged 3 commits into from
Aug 6, 2021
Merged

Make Java AstNode public #8953

merged 3 commits into from
Aug 6, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Aug 4, 2021

This makes the Java AstNode base class public so applications can construct an AST using a common type for all AST nodes.

@jlowe jlowe added Java Affects Java cuDF API. 4 - Needs cuDF (Java) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 4, 2021
@jlowe jlowe self-assigned this Aug 4, 2021
@jlowe jlowe requested a review from a team as a code owner August 4, 2021 16:10
@codecov
Copy link

codecov bot commented Aug 5, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@db63f61). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #8953   +/-   ##
===============================================
  Coverage                ?   10.59%           
===============================================
  Files                   ?      116           
  Lines                   ?    19036           
  Branches                ?        0           
===============================================
  Hits                    ?     2017           
  Misses                  ?    17019           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db63f61...d37e1ac. Read the comment docs.

@jlowe
Copy link
Member Author

jlowe commented Aug 6, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5de9def into rapidsai:branch-21.10 Aug 6, 2021
shwina pushed a commit to shwina/cudf that referenced this pull request Aug 9, 2021
@jlowe @shwina
Make Java AstNode public (rapidsai#8953)
0219d60 
This makes the Java `AstNode` base class public so applications can construct an AST using a common type for all AST nodes.

Authors:
  - Jason Lowe (https://github.com/jlowe)

Approvers:
  - Robert (Bobby) Evans (https://github.com/revans2)

URL: rapidsai#8953
@jlowe jlowe deleted the jni-ast-node-public branch September 10, 2021 15:47
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 approved these changes

Assignees

@jlowe jlowe

Labels
4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlowe @revans2 @vyasr