Add spans and more include guidelines to libcudf developer guide [skipci] #8931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhemstad
approved these changes
Aug 3, 2021
trxcllnt
approved these changes
Aug 5, 2021
vuule
reviewed
Aug 5, 2021
Comment on lines
+271
to
+272
| If you are definining internal (detail) functions that operate on vectors, use spans for the input | ||
| vector parameters rather than a specific vector type, to make your functions more widely applicable. |
There was a problem hiding this comment.
Should we include the difference between span<T> const and span<T const> here?
Something like "For input span function parameters, use span<T const>, instead of span<T> const".
There was a problem hiding this comment.
Good idea, will add that.
harrism
changed the title
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a section on
spantypes, and adds a few more guidelines on #includes.