-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw KeyError when accessing field from struct with nonexistent key #8880
Throw KeyError when accessing field from struct with nonexistent key #8880
Conversation
Thanks for the fix! Could you also please add a test in |
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #8880 +/- ##
================================================
- Coverage 10.67% 10.61% -0.07%
================================================
Files 110 116 +6
Lines 18271 19001 +730
================================================
+ Hits 1951 2017 +66
- Misses 16320 16984 +664
Continue to review full report at Codecov.
|
Thanks! This looks great -- just need a test or two in |
…existent struct fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work, @NV-jpt
Awesome!! Thank you for all the help @shwina & @beckernick ! |
One of the checks was not successful (gpuCI/cudf/gpu/java — Build #429 failed in 44 min). Is there something I can do to resolve this? |
rerun tests |
Doesn't look like an issue with this PR. Just reran tests -- let's see if it passes this time around. |
Thank you, @shwina! I could not figure out how to rerun them |
Ah, I'm not sure if it's available to everyone, but the comment |
Oh no, it did! |
@gpucibot merge |
This should unblock #8874 |
PR response to issue #8875