-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python binding for quarters #8862
Python binding for quarters #8862
Conversation
Co-authored-by: David Wendt <[email protected]>
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #8862 +/- ##
===============================================
Coverage ? 10.58%
===============================================
Files ? 116
Lines ? 19067
Branches ? 0
===============================================
Hits ? 2018
Misses ? 17049
Partials ? 0 Continue to review full report at Codecov.
|
rerun tests |
Co-authored-by: Michael Wang <[email protected]>
rerun tests |
2 similar comments
rerun tests |
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, good work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could probably save some memory that would go un-used here.
@beckernick Is it a necessity, in this case, we should be matching pandas return dtype(i.e., int64
)?
The related libcudf method also seems to be returning int16
, instead of int8
: https://github.com/rapidsai/cudf/pull/8779/files#diff-76e529bce1f51fca7ea3193f09c6e95906410a82bcc03a9271553b8527468052R218
@shaneding any reason why we choose int16
over the lowest possible dtype
?
The main reason was because within |
@gpucibot merge |
Closes #8676.
This PR adds python bindings for #8779.