Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Java bindings for AST transform #8846

Merged
merged 7 commits into from
Jul 28, 2021
Merged

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Jul 23, 2021

This adds Java bindings to the AST transform operation that computes a new column from an input table using an AST expression.

@jlowe jlowe added feature request New feature or request Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change labels Jul 23, 2021
@jlowe jlowe self-assigned this Jul 23, 2021
@jlowe jlowe requested a review from a team as a code owner July 23, 2021 21:58
@github-actions github-actions bot added the CMake CMake build issue label Jul 23, 2021
@jlowe jlowe requested a review from revans2 July 23, 2021 21:58
@codecov
Copy link

codecov bot commented Jul 24, 2021

Codecov Report

Merging #8846 (6dadc59) into branch-21.10 (18f7c01) will decrease coverage by 0.09%.
The diff coverage is n/a.

❗ Current head 6dadc59 differs from pull request most recent head a95c9cb. Consider uploading reports for the commit a95c9cb to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.10    #8846      +/-   ##
================================================
- Coverage         10.67%   10.58%   -0.10%     
================================================
  Files               110      116       +6     
  Lines             18271    18654     +383     
================================================
+ Hits               1951     1974      +23     
- Misses            16320    16680     +360     
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/column.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/lists.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/numerical.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/string.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/struct.py 0.00% <ø> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <ø> (ø)
python/cudf/cudf/core/frame.py 0.00% <ø> (ø)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7ba345...a95c9cb. Read the comment docs.

Copy link
Contributor

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good as a first go at the AST APIs. I think the APIs look good enough that we can probably avoid the need to change the user facing APIs too much in the future.

@jlowe
Copy link
Member Author

jlowe commented Jul 27, 2021

rerun tests

1 similar comment
@jlowe
Copy link
Member Author

jlowe commented Jul 27, 2021

rerun tests

@jlowe
Copy link
Member Author

jlowe commented Jul 27, 2021

rerun tests

@jlowe
Copy link
Member Author

jlowe commented Jul 28, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ac8cc53 into rapidsai:branch-21.10 Jul 28, 2021
@vyasr vyasr added this to the Conditional Joins milestone Jul 30, 2021
@jlowe jlowe deleted the jni-ast branch September 10, 2021 15:47
@GregoryKimball GregoryKimball removed this from the Conditional Joins milestone Oct 24, 2022
@GregoryKimball GregoryKimball added this to the Expression evaluation milestone Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CMake build issue feature request New feature or request Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants