Fixes issue with null struct columns in ORC reader #8819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orc_struct_null_issue
github-actions
bot
added
Python
rgsl888prabhu
changed the title
rgsl888prabhu
added
3 - Ready for Review
rgsl888prabhu
requested review from
jrhemstad,
vuule,
vyasr and
brandon-b-miller
vuule
requested changes
Jul 21, 2021
github-actions
bot
added
Python
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8819 +/- ##
===============================================
Coverage ? 10.59%
===============================================
Files ? 116
Lines ? 19033
Branches ? 0
===============================================
Hits ? 2017
Misses ? 17016
Partials ? 0 Continue to review full report at Codecov.
|
galipremsagar
approved these changes
Jul 22, 2021
devavret
reviewed
Jul 22, 2021
devavret
reviewed
Jul 22, 2021
devavret
reviewed
Jul 22, 2021
| const size_t level, | ||
| const uint32_t id, | ||
| bool& has_timestamp_column, | ||
| bool& has_nested_column) |
There was a problem hiding this comment.
If these are not in/out params, why not just return them and AND them at callsite
There was a problem hiding this comment.
It is a recursive function and it might be easier for reader this way compared to returning.
devavret
reviewed
Jul 22, 2021
devavret
approved these changes
Jul 22, 2021
vuule
added
5 - Ready to Merge
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of liborc, pyarrow and pyorc:
If the parent has a null element, that element is skipped while writing child data, and same goes with mask
So, you would have to keep track of null count and null mask in parent column, so that you can merge both the parent and child null masks.
In case of pyspark, spark:
If the parent has a null element, and if child column also has null element, then upper explanation holds.
But if all the child rows are valid, then you need to copy the mask from parent.
These scenarios have been take care in the code changes.
Earlier struct column and its child columns used to be in the same level of nesting, but since we need parent null mask before decoding child, changes have been made so that child columns will be moved one level down for all types of nested columns.
closes #8704