Refactor conditional joins #8815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… outstanding PR comments from PR rapidsai#8214.
vyasr
added
3 - Ready for Review
|
@harrism @hyperbolic2346 I've re-requested your review here since I think this is the part of #8783 that requires the least knowledge of the AST internals. |
hyperbolic2346
requested changes
Jul 21, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #8815 +/- ##
================================================
- Coverage 10.67% 10.59% -0.09%
================================================
Files 110 116 +6
Lines 18271 19037 +766
================================================
+ Hits 1951 2017 +66
- Misses 16320 17020 +700
Continue to review full report at Codecov.
|
harrism
approved these changes
Jul 27, 2021
…garding shuffle and warp syncs.
hyperbolic2346
approved these changes
Jul 28, 2021
|
@gpucibot merge |
This was referenced Jul 29, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8214 made use of a number of functions defined for hash joins, but to expedite the review process no attempt was made to improve the organization of code into shared files. This PR improves that organization for improved conceptual clarity and faster parallel compilation and recompilation times. As a result, most of the changes in this PR are simply preexisting code to new files, as well as removing a number of unnecessary headers. The main new code is a few minor improvements that were suggested but not implemented on #8214 are included, mainly 1) a new
nullable(table_view const&)API for checking if any columns in a table are nullable (requested here), and 2) some extra comments on the behavior of conditional joins when the condition returns null (requested here).Contributes to #8145.