Provide a better error message when CUDA::cuda_driver not found
#8794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuDF JITIFY sources require the the CUDA driver ( libcuda.so ) or stub to exist for correct compilation/linking. If they can't be found explain why, instead of producing a bad error message
robertmaynard
added
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8794 +/- ##
===============================================
Coverage ? 10.49%
===============================================
Files ? 116
Lines ? 18985
Branches ? 0
===============================================
Hits ? 1993
Misses ? 16992
Partials ? 0 Continue to review full report at Codecov.
|
|
As one who was victim of the build failure that this PR addresses, I have verified this change works for me. |
harrism
requested changes
Jul 20, 2021
Co-authored-by: Mark Harris <[email protected]>
harrism
approved these changes
Jul 22, 2021
|
@gpucibot merge |
robertmaynard
deleted the
fea/better_error_message_when_libcuda_cant_be_found
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cuDF JITIFY sources require the the CUDA driver ( libcuda.so ) or
stub to exist for correct compilation/linking. If they can't be
found explain why, instead of producing a bad error message