Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix issues with MultiIndex in dropna, stack & reset_index #8753

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

galipremsagar
Copy link
Contributor

Fixes: #3583

This PR contains fixes for :

  • stack: Where the MultiIndex names are not being assigned correctly in from_table call.
  • dropna: Where the MultiIndex names are not being preserved after a libcudf API call.
  • reset_index: Where the MultiIndex level names are not being materialized correctly when the index is reset.

@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@18f7c01). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head b8f4b26 differs from pull request most recent head 4afefaf. Consider uploading reports for the commit 4afefaf to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8753   +/-   ##
===============================================
  Coverage                ?   10.68%           
===============================================
  Files                   ?      110           
  Lines                   ?    18648           
  Branches                ?        0           
===============================================
  Hits                    ?     1993           
  Misses                  ?    16655           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18f7c01...4afefaf. Read the comment docs.

@shwina
Copy link
Contributor

shwina commented Jul 16, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ceb3922 into rapidsai:branch-21.08 Jul 16, 2021
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Jul 16, 2021
@galipremsagar galipremsagar linked an issue Jul 23, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
3 participants