Write pandas extension types to parquet file metadata #8749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Writing pandas extension types to parquet file Prevents nullable columns to be read as float columns with NaNs
devavret
requested review from
charlesbluca,
rgsl888prabhu and
galipremsagar
and removed request for
rgsl888prabhu
devavret
added
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8749 +/- ##
===============================================
Coverage ? 10.53%
===============================================
Files ? 116
Lines ? 18916
Branches ? 0
===============================================
Hits ? 1993
Misses ? 16923
Partials ? 0 Continue to review full report at Codecov.
|
galipremsagar
requested changes
Jul 15, 2021
galipremsagar
approved these changes
Jul 16, 2021
galipremsagar
added
5 - Ready to Merge
|
@gpucibot merge |
1 similar comment
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 19, 2021
Not sure if it was the timing of the gpuCI `isort` bump relative to the updated pre-commit hooks here, but #8749 introduced a sorting error in `utils.pyx` that wasn't caught by gpuCI at the time of merging. Authors: - Charles Blackmon-Luca (https://github.com/charlesbluca) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) - Nghia Truong (https://github.com/ttnghia) URL: #8771
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents nullable columns to be read as float columns with NaNs when reading with pandas.
Fixes #8688