Fix min/max sorted groupby aggregation on string column with nulls (argmin, argmax sentinel value missing on nulls) #8731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikeyann
added
bug
karthikeyann
changed the title
jrhemstad
approved these changes
Jul 13, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8731 +/- ##
===============================================
Coverage ? 10.67%
===============================================
Files ? 109
Lines ? 18670
Branches ? 0
===============================================
Hits ? 1993
Misses ? 16677
Partials ? 0 Continue to review full report at Codecov.
|
jlowe
approved these changes
Jul 13, 2021
There was a problem hiding this comment.
Thanks for the quick turnaround, @karthikeyann! The RAPIDS Accelerator tests that were failing due to this before now pass with this change.
harrism
approved these changes
Jul 13, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8717
Usages of argmin, argmax depends on presence of sentinel values at nulls (ARGMIN_SENTINEL, ARGMAX_SENTINEL), group_argmin and group_argmax need to guarantee these sentinel values in their output. but
cudf::detaill:gatherdoesn't guarantee that. This PR fixes this.cudf::detail::gatherwiththrust::gather_ifon indices to fix missing SENTINEL values for argmin, argmax.