Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slicing from struct columns and accessing struct columns #8719

Merged
merged 3 commits into from
Jul 20, 2021
Merged

Fix slicing from struct columns and accessing struct columns #8719

merged 3 commits into from
Jul 20, 2021

Conversation

shaneding
Copy link
Contributor

@shaneding shaneding commented Jul 12, 2021 •
edited by harrism
Loading

Fixes #8718

@shaneding shaneding requested a review from a team as a code owner July 12, 2021 22:35
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jul 12, 2021
@shaneding shaneding added feature request New feature or request non-breaking Non-breaking change labels Jul 12, 2021
@harrism harrism changed the title fixed slicing from struct columns and accessing struct columns Fix slicing from struct columns and accessing struct columns Jul 12, 2021
@shaneding shaneding mentioned this pull request Jul 13, 2021
Closed
galipremsagar
galipremsagar previously approved these changes Jul 15, 2021
View reviewed changes
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Jul 15, 2021
isVoid
isVoid reviewed Jul 16, 2021
View reviewed changes
Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another nit, feel free to ignore.

python/cudf/cudf/tests/test_struct.py Show resolved Hide resolved
@galipremsagar galipremsagar removed the 5 - Ready to Merge Testing and reviews complete, ready to merge label Jul 16, 2021
@galipremsagar
Copy link
Contributor

@shaneding Looks like there are some struct related pytest failures, could you look into it?

@galipremsagar galipremsagar dismissed their stale review July 16, 2021 18:49

tests failing

@galipremsagar
Copy link
Contributor

rerun tests

@codecov
Copy link

codecov bot commented Jul 20, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@d07f994). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8719   +/-   ##
===============================================
  Coverage                ?   10.53%           
===============================================
  Files                   ?      116           
  Lines                   ?    18916           
  Branches                ?        0           
===============================================
  Hits                    ?     1993           
  Misses                  ?    16923           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d07f994...b7020e7. Read the comment docs.

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Jul 20, 2021
@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4c70af4 into rapidsai:branch-21.08 Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isVoid isVoid isVoid left review comments

@galipremsagar galipremsagar galipremsagar approved these changes

@marlenezw marlenezw Awaiting requested review from marlenezw

@skirui-source skirui-source Awaiting requested review from skirui-source

Assignees

@shaneding shaneding

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Incorrect slice on struct column.
3 participants
@shaneding @galipremsagar @isVoid