Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: replace_nulls_policy functor not returning correct indices for gathermap #8699

Merged
merged 2 commits into from
Jul 16, 2021

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Jul 9, 2021

Closes #8673

This PR fixes a bug in the functor for replace_nulls(replace_policy). The current functor assumes that the second element of the pair is discarded and is arbitrarily returned true. This breaks the associative constraints for inclusive_scan functors.

@isVoid isVoid requested review from a team as code owners July 9, 2021 01:12
@github-actions github-actions bot added Python Affects Python cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Jul 9, 2021
@isVoid isVoid added bug Something isn't working non-breaking Non-breaking change labels Jul 9, 2021
@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@8aaf8e6). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 14596f6 differs from pull request most recent head d320e1f. Consider uploading reports for the commit d320e1f to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8699   +/-   ##
===============================================
  Coverage                ?   10.62%           
===============================================
  Files                   ?      109           
  Lines                   ?    18291           
  Branches                ?        0           
===============================================
  Hits                    ?     1943           
  Misses                  ?    16348           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aaf8e6...d320e1f. Read the comment docs.

Copy link
Contributor

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pytest approval

@galipremsagar galipremsagar added the 4 - Needs Review Waiting for reviewer to review or respond label Jul 9, 2021
@isVoid isVoid added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 4 - Needs Review Waiting for reviewer to review or respond labels Jul 15, 2021
@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 18f7c01 into rapidsai:branch-21.08 Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] fillna forward and backward fill methods fail to replace long ranges of missing values
4 participants