Pin *arrow to use *cuda in run
#8651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though we pinned `*cuda` in `host`, this didn't carry over to the `run` dependencies. To fix this, tack on `*cuda` to `pyarrow`'s `pin_compatible` line. This seems to do the right thing when matching the build string.
jakirkham
added
3 - Ready for Review
Even though we pinned `*cuda` in `host`, this didn't carry over to the `run` dependencies. To fix this, add a `arrow-cpp` constraint with `*cuda`. This seems to do the right thing when matching the build string.
jakirkham
changed the title
pyarrow to use *cuda in run*arrow to use *cuda in run
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8651 +/- ##
===============================================
Coverage ? 10.61%
===============================================
Files ? 109
Lines ? 18648
Branches ? 0
===============================================
Hits ? 1980
Misses ? 16668
Partials ? 0 Continue to review full report at Codecov.
|
jjacobelli
approved these changes
Jul 5, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to PR ( #8637 )
Even though we pinned
*cudainhost, this didn't carry over to therundependencies. To fix this, tack on*cudatopyarrowandarrow-cppinrun. This should fix installation errors where the CPU builds were getting pulled in unintentionally.cc @ajschmidt8 @charlesbluca @pentschev