Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pct_change to Series #8650

Merged
merged 4 commits into from
Jul 22, 2021
Merged

Conversation

TravisHester
Copy link
Contributor

@TravisHester TravisHester commented Jul 2, 2021

closes #6133
closes #8727
unit test in test_stats.py: test_series_pct_change

Added pct_change function for Series. The limit and freq arguments could not be fully implemented due to lack of implementation in Series.fillna() and Series.shift() functions respectively.

@TravisHester TravisHester requested a review from a team as a code owner July 2, 2021 20:41
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jul 2, 2021
@TravisHester TravisHester added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change feature request New feature or request labels Jul 2, 2021
@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@167c2b7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             branch-21.08   #8650   +/-   ##
==============================================
  Coverage                ?   9.17%           
==============================================
  Files                   ?     116           
  Lines                   ?   24062           
  Branches                ?       0           
==============================================
  Hits                    ?    2207           
  Misses                  ?   21855           
  Partials                ?       0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 167c2b7...aa99174. Read the comment docs.

Copy link
Member

@beckernick beckernick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. One small question

python/cudf/cudf/core/series.py Outdated Show resolved Hide resolved
Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shwina
Copy link
Contributor

shwina commented Jul 20, 2021

rerun tests

@quasiben
Copy link
Member

@gpucibot merge

@ajschmidt8 ajschmidt8 dismissed beckernick’s stale review July 22, 2021 14:20

Nick is OoO and his concerns have been addressed.

@ajschmidt8
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit eddb2f8 into rapidsai:branch-21.08 Jul 22, 2021
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Add support for "pad" as fill_method option for Series.fillna [FEA] pct_change
7 participants