-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added pct_change to Series #8650
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8650 +/- ##
==============================================
Coverage ? 9.17%
==============================================
Files ? 116
Lines ? 24062
Branches ? 0
==============================================
Hits ? 2207
Misses ? 21855
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. One small question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
rerun tests |
@gpucibot merge |
Nick is OoO and his concerns have been addressed.
@gpucibot merge |
closes #6133
closes #8727
unit test in test_stats.py: test_series_pct_change
Added pct_change function for Series. The limit and freq arguments could not be fully implemented due to lack of implementation in Series.fillna() and Series.shift() functions respectively.