Support multi-char case conversion in capitalize function #8647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
bug
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8647 +/- ##
================================================
+ Coverage 10.60% 10.61% +0.01%
================================================
Files 109 109
Lines 18280 18645 +365
================================================
+ Hits 1938 1980 +42
- Misses 16342 16665 +323
Continue to review full report at Codecov.
|
|
@firestarman will you be able to check if this fixes #8644 for you? |
Thanks @davidwendt , it can fix the issue #8644 . |
rgsl888prabhu
approved these changes
Jul 5, 2021
harrism
approved these changes
Jul 6, 2021
harrism
added
5 - Ready to Merge
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8644
Multi-character case conversion support added for strings
to_upperandto_loweris reused forcapitalizeandtitlefunctions. For example, converting from a single characterʼnto its upper-case equivalent is actually two distinct characters'N(apostrophe and capital-N). This is different than conversion of a single multi-byte character to another single multi-byte character with different byte lengths. Here a single character is converted into two characters.