-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix repeated mangled names in read_csv with duplicate column names #8645
Fix repeated mangled names in read_csv with duplicate column names #8645
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8645 +/- ##
================================================
+ Coverage 10.60% 10.61% +0.01%
================================================
Files 109 109
Lines 18280 18645 +365
================================================
+ Hits 1938 1980 +42
- Misses 16342 16665 +323
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just remembered - please add a test case that exercises the behavior change.
rerun tests |
@gpucibot merge |
Fixes mangled name bug
read_csv
with duplicate columns.mismatch with pandas behavior.
csv file:
Pandas:
cudf: (21.08 nightly docker)
This PR fixes this issue.
Related info (sparks):
Spark duplicate column naming.
https://issues.apache.org/jira/browse/SPARK-16896
apache/spark#14745
cudf sparks addon doesn't use libcudf names. So, this PR does not affect it.